search

pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.01k stars 557 forks source link

Rewrite the README to reflect the v6 changes #3109

Open rdwebdesign opened 1 month ago

rdwebdesign commented 1 month ago

Note: This PR depends on the graphics repo PR to include the new images.

What does this PR aim to accomplish?

Change the README file to reflect the v6 changes, showing the new features and removing the deprecated ones.

How does this PR accomplish the above?

Adding new images a and changing texts where needed.

By submitting this pull request, I confirm the following:

  1. I have read and understood the contributors guide, as well as this entire template. I understand which branch to base my commits and Pull Requests against.
  2. I have commented my proposed changes within the code and I have tested my changes.
  3. I am willing to help maintain this change if there are issues with it later.
  4. It is compatible with the EUPL 1.2 license
  5. I have squashed any insignificant commits. (git rebase)
  6. I have checked that another pull request for this purpose does not exist.
  7. I have considered, and confirmed that this submission will be valuable to others.
  8. I accept that this submission may not be used, and the pull request closed at the will of the maintainer.
  9. I give this submission freely, and claim no ownership to its content.
rdwebdesign commented 5 days ago

What is the browser-stack-badge for?

I really don't know. This badge was there since a long time ago. I will remove it because we don't use this service.

rdwebdesign commented 5 days ago

What is the browser-stack-badge for? I don't think we use that service...

  • Done: badge removed

I would remove the link to disourse on how to access the web interface.

  • Done: Agree... link removed

We can now also access via https

  • Done: note added to make the use of http/https clear;

Remove "forgot your password?"

  • Done: text removed

Passwort protection - maybe add 2FA + Screenshot

  • I will change the "login screen" image in a future PR.
PromoFaux commented 5 days ago

This badge was there since a long time ago. I will remove it because we don't use this service.

We might not have used it recently, but we have a sponsored plan with the service, so perhaps put it back for the time being (I think it was a condition of the plan)

rdwebdesign commented 5 days ago

I will wait until we decide what will happen with https://github.com/pi-hole/web/pull/3139.

yubiuser commented 5 days ago

sponsored plan with the service

Do you want to re-enable the service to check the web interface?