pi-hole / web

Pi-hole Dashboard for stats and more
https://pi-hole.net
Other
2.02k stars 560 forks source link

Query Log - Long Domains push columns off page #555

Closed AzureMarker closed 6 years ago

AzureMarker commented 7 years ago

@WelcovIT commented on Tue Jul 25 2017

In raising this issue, I confirm the following (please check boxes, eg [X]) Failure to fill the template will close your issue:

How familiar are you with the codebase?:

2


[BUG REPORT | OTHER]:

Please submit your feature request here, so it is votable by the community. It's also easier for us to track.

[BUG | ISSUE] Expected Behaviour: Domain field should wrap long queries. I have seen some long queries wrap, but if they're too long, they won't wrap at all.

[BUG | ISSUE] Actual Behaviour: The domain field pushes Client, Status, and Action columns off the page

[BUG | ISSUE] Steps to reproduce: Produce an extremely long query. Was told to submit this bug here from my feature request on the discourse: https://discourse.pi-hole.net/t/query-log-domain-field-needs-to-wrap/4222

(Optional) Debug token generated by pihole -d:

<token>

This template was created based on the work of udemy-dl.

AzureMarker commented 7 years ago

Confirmed that long domain names take up a long space. Tested using this domain :wink: this.is.a.really.really.really.long.domain.name.and.i.really.hope.i.dont.see.the.whole.thing.in.the.query.log.but.i.probably.will.so.why.not.stop.now.com We can either cut it off at a certain point (...) or wrap it.

jacobsalmela commented 6 years ago

Fixed in v3.2