Currently the rover BlinkAllLights function leaves the led state toggled (off if they were on before, and on if not).
I would expect the lights to always all be left off after doing a 'blink' operation, so that is what this PR does. I also increased the default blinkCount to give 3 'blinks' from either starting state.
Arguably, they should instead just be kept in their initial state. If we prefer that, we probably need to ensure the blinkCount param is always an even number.
...Actually, I think that is better, and blinkCount should really count full 'on and off' toggles. Going to open a new PR instead of this.
Currently the rover BlinkAllLights function leaves the led state toggled (off if they were on before, and on if not).
I would expect the lights to always all be left off after doing a 'blink' operation, so that is what this PR does. I also increased the default
blinkCountto give 3 'blinks' from either starting state.Arguably, they should instead just be kept in their initial state. If we prefer that, we probably need to ensure the
blinkCountparam is always an even number....Actually, I think that is better, and blinkCount should really count full 'on and off' toggles. Going to open a new PR instead of this.