pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Set package version using environment variable #551

Closed jcapona closed 2 years ago

jcapona commented 2 years ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

Set package version on build-time using the PYTHON_PACKAGE_VERSION environment variable:

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 2 years ago

Codecov Report

Base: 57.00% // Head: 57.02% // Increases project coverage by +0.01% :tada:

Coverage data is based on head (6ee3988) compared to base (c2bac34). Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #551 +/- ## ========================================== + Coverage 57.00% 57.02% +0.01% ========================================== Files 146 146 Lines 6920 6918 -2 ========================================== Hits 3945 3945 + Misses 2975 2973 -2 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `57.02% <100.00%> (+0.01%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/551?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [pitop/version.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/551/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmVyc2lvbi5weQ==) | `100.00% <100.00%> (+25.00%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.