pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Detect and raise exception when IMU is used with new Expansion Plate #555

Closed jcapona closed 1 year ago

jcapona commented 1 year ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 year ago

Codecov Report

Base: 56.99% // Head: 57.74% // Increases project coverage by +0.74% :tada:

Coverage data is based on head (6130f9a) compared to base (fc2f43a). Patch coverage: 20.00% of modified lines in pull request are covered.

:exclamation: Current head 6130f9a differs from pull request most recent head d3b52aa. Consider uploading reports for the commit d3b52aa to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #555 +/- ## ========================================== + Coverage 56.99% 57.74% +0.74% ========================================== Files 133 147 +14 Lines 6439 6962 +523 ========================================== + Hits 3670 4020 +350 - Misses 2769 2942 +173 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `57.74% <20.00%> (+0.74%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [pitop/system/device.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3Avc3lzdGVtL2RldmljZS5weQ==) | `26.47% <0.00%> (ø)` | | | [pitop/pma/imu\_controller.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL2ltdV9jb250cm9sbGVyLnB5) | `32.72% <25.00%> (-0.20%)` | :arrow_down: | | [pitop/miniscreen/oled/oled.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvbWluaXNjcmVlbi9vbGVkL29sZWQucHk=) | `74.75% <0.00%> (ø)` | | | [pitop/common/switch\_user.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvY29tbW9uL3N3aXRjaF91c2VyLnB5) | | | | [pitop/keyboard/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3Ava2V5Ym9hcmQvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | | [pitop/pma/servo\_motor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL3NlcnZvX21vdG9yLnB5) | `67.67% <0.00%> (ø)` | | | [pitop/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvX19pbml0X18ucHk=) | `100.00% <0.00%> (ø)` | | | [pitop/pma/potentiometer.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL3BvdGVudGlvbWV0ZXIucHk=) | `73.33% <0.00%> (ø)` | | | [pitop/pma/imu.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL2ltdS5weQ==) | `46.91% <0.00%> (ø)` | | | [pitop/pma/ultrasonic\_sensor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL3VsdHJhc29uaWNfc2Vuc29yLnB5) | `77.61% <0.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/555/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.