angusjfw commented 1 year ago

Status	Ticket/Issue
Ready/Hold	Ticket

Main changes

-

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

I added dist loadfile option to xdist, so now to disable xdist you have to pass --dist no as well as -n0 . Loadfile ensures tests in the same file are not run concurrently, which helps to avoid an issue with tests using gpiozero, where closing a component on a particular port in one process causes it to be closed in others.

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 year ago

Codecov Report

Base: 56.97% // Head: 58.72% // Increases project coverage by +1.74% :tada:

Coverage data is based on head (b243428) compared to base (b8e144f). Patch coverage: 80.84% of modified lines in pull request are covered.

:exclamation: Current head b243428 differs from pull request most recent head 3bc099f. Consider uploading reports for the commit 3bc099f to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #560 +/- ## ========================================== + Coverage 56.97% 58.72% +1.74% ========================================== Files 133 140 +7 Lines 6443 6737 +294 ========================================== + Hits 3671 3956 +285 - Misses 2772 2781 +9 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `58.72% <80.84%> (+1.74%)` | :arrow_up: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [pitop/miniscreen/oled/oled.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvbWluaXNjcmVlbi9vbGVkL29sZWQucHk=) | `74.75% <ø> (ø)` | | | [pitop/pma/imu\_controller.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvcG1hL2ltdV9jb250cm9sbGVyLnB5) | `32.91% <ø> (+0.19%)` | :arrow_up: | | [pitop/system/device.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3Avc3lzdGVtL2RldmljZS5weQ==) | `26.47% <0.00%> (ø)` | | | [pitop/virtual\_hardware/mock\_hardware/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9tb2NrX2hhcmR3YXJlL19faW5pdF9fLnB5) | `53.33% <53.33%> (ø)` | | | [...virtual\_hardware/mock\_hardware/vendor/Mock/GPIO.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9tb2NrX2hhcmR3YXJlL3ZlbmRvci9Nb2NrL0dQSU8ucHk=) | `53.39% <53.39%> (ø)` | | | [pitop/virtual\_hardware/simulation/simulation.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9zaW11bGF0aW9uL3NpbXVsYXRpb24ucHk=) | `93.45% <93.45%> (ø)` | | | [pitop/virtual\_hardware/simulation/simsprite.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9zaW11bGF0aW9uL3NpbXNwcml0ZS5weQ==) | `95.38% <95.38%> (ø)` | | | [pitop/virtual\_hardware/simulation/sprites.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9zaW11bGF0aW9uL3Nwcml0ZXMucHk=) | `95.65% <95.65%> (ø)` | | | [pitop/system/pitop.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3Avc3lzdGVtL3BpdG9wLnB5) | `100.00% <100.00%> (ø)` | | | [pitop/virtual\_hardware/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGl0b3AvdmlydHVhbF9oYXJkd2FyZS9fX2luaXRfXy5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [4 more](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/560/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.