Rename package pitop.virtual_hardware to pitop.simulation

[angusjfw]

Status	Ticket/Issue
Ready/Hold	Ticket

Main changes

• We think maybe this is just more user friendly, easier to remember, and less open-ended. from pitop.simulate import simulation

Other notes (e.g. implementation quirks, edge cases, questions / issues)

• In debian/control I marked this as breaking & replacing the virtual-hardware package - not certain about that

Manual testing tips

• Install from experimental/unstable - does it replace virtual-hardware, does it work

[codecov[bot]]

Codecov Report

Base: 60.46% // Head: 60.46% // No change to project coverage :thumbsup:

Coverage data is based on head (6377bce) compared to base (024f38a). Patch coverage: 100.00% of modified lines in pull request are covered.

:exclamation: Current head 6377bce differs from pull request most recent head 384eac1. Consider uploading reports for the commit 384eac1 to get more accurate results

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #574 +/- ## ======================================= Coverage 60.46% 60.46% ======================================= Files 147 147 Lines 7292 7292 ======================================= Hits 4409 4409 Misses 2883 2883 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `60.46% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [...ges/simulation/pitop/simulation/images/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL2ltYWdlcy9fX2luaXRfXy5weQ==) | `100.00% <ø> (ø)` | | | [packages/simulation/pitop/simulation/simsprite.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXNwcml0ZS5weQ==) | `38.46% <ø> (ø)` | | | [packages/simulation/pitop/simulation/simulation.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXVsYXRpb24ucHk=) | `49.53% <ø> (ø)` | | | [...op/simulation/virtual\_hardware/vendor/Mock/GPIO.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3ZpcnR1YWxfaGFyZHdhcmUvdmVuZG9yL01vY2svR1BJTy5weQ==) | `53.39% <ø> (ø)` | | | [...imulation/virtual\_hardware/vendor/Mock/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3ZpcnR1YWxfaGFyZHdhcmUvdmVuZG9yL01vY2svX19pbml0X18ucHk=) | `100.00% <ø> (ø)` | | | [packages/pitop/pitop/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcGl0b3AvcGl0b3AvX19pbml0X18ucHk=) | `100.00% <100.00%> (ø)` | | | [packages/simulation/pitop/simulation/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL19faW5pdF9fLnB5) | `100.00% <100.00%> (ø)` | | | [packages/simulation/pitop/simulation/sprites.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3Nwcml0ZXMucHk=) | `47.82% <100.00%> (ø)` | | | [...tion/pitop/simulation/virtual\_hardware/\_\_init\_\_.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/574/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3ZpcnR1YWxfaGFyZHdhcmUvX19pbml0X18ucHk=) | `53.33% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

[lgtm-com[bot]]

This pull request introduces 2 alerts and fixes 2 when merging 6377bce21fa1a067877bdc12728d23d7c64d8ee6 into 024f38a5d7d297263e041f38aab08ad71a241837 - view on LGTM.com

new alerts:

• 2 for Module-level cyclic import

fixed alerts:

• 2 for Module-level cyclic import

[lgtm-com[bot]]

This pull request introduces 2 alerts and fixes 2 when merging 384eac1dee8b403df42f3fce961cff174d0e02a7 into 024f38a5d7d297263e041f38aab08ad71a241837 - view on LGTM.com

new alerts:

• 2 for Module-level cyclic import

fixed alerts:

• 2 for Module-level cyclic import