Closed angusjfw closed 1 year ago
Base: 60.49% // Head: 60.49% // No change to project coverage :thumbsup:
Coverage data is based on head (
bd70158
) compared to base (075ffbe
). Patch has no changes to coverable lines.
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Why would this not be pitop.cli
? Just wondering
Why would this not be
pitop.cli
? Just wondering
We decided the pitopcli
should not be a subpackage of pitop
as it acts as a separate interface to the SDK functionality rather than a part of it. So the different naming is to reflect this.
That said, I don't think we've got this fully resolved yet. For one thing it would probably have made more sense to remove it as a python dependency of the pitop package here, and instead include it in the OS via a debian dependency, to reflect that point that it's not a required part of the python sdk. Possibly we should also name it differently in debian to reflect it is a standalone tool: pitopcli
not python3-pitop-cli
.
Main changes
Screenshots (feature, test output, profiling, dev tools etc)
[insert screenshots here]
Other notes (e.g. implementation quirks, edge cases, questions / issues)
-
Manual testing tips
-
Tag anyone who definitely needs to review or help
-