pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Update detection of pi user default password #584

Closed jcapona closed 1 year ago

jcapona commented 1 year ago

Main changes

Update detection of pi user default password; since pi-topOS is now built on top of the latest Raspberry Pi image, we manually set the username and password; this PR updates the text that is looked up in /etc/shadow based on this

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 year ago

Codecov Report

Base: 60.51% // Head: 60.51% // No change to project coverage :thumbsup:

Coverage data is based on head (823572b) compared to base (c22dff4). Patch has no changes to coverable lines.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #584 +/- ## ======================================= Coverage 60.51% 60.51% ======================================= Files 147 147 Lines 7311 7311 ======================================= Hits 4424 4424 Misses 2887 2887 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `60.51% <ø> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.