Open jcapona opened 1 year ago
Base: 0.00% // Head: 60.51% // Increases project coverage by +60.51%
:tada:
Coverage data is based on head (
bd81adb
) compared to base (1bf3128
). Patch coverage: 72.00% of modified lines in pull request are covered.:exclamation: Current head bd81adb differs from pull request most recent head 2873910. Consider uploading reports for the commit 2873910 to get more accurate results
:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Main changes
Improve
PTDMSubscribeClient
structure by only subscribing to the events that were marked as relevant according to the dictionary passed to theinitialise
method. By doing this, overhead is reduced since it's not necessary to filter the received messages once they're received since now when that happens, we're 100% sure it's from an event we're interested in.Couldn't remove the polling since this is required to stop the
PTDMSubscribeClient
's internal thread.Screenshots (feature, test output, profiling, dev tools etc)
[insert screenshots here]
Other notes (e.g. implementation quirks, edge cases, questions / issues)
-
Manual testing tips
-
Tag anyone who definitely needs to review or help
-