search

pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Simulate PMA components #594

Closed jcapona closed 1 year ago

jcapona commented 1 year ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

lgtm-com[bot] commented 1 year ago

This pull request fixes 2 alerts when merging 5a0299e69feea61e0c84e6fcde957016b8b6c80e into de41307f005ebf24bf3ac59ebf2294ba783afe3f - view on LGTM.com

fixed alerts:

Heads-up: LGTM.com's PR analysis will be disabled on the 5th of December, and LGTM.com will be shut down ⏻ completely on the 16th of December 2022. Please enable GitHub code scanning, which uses the same CodeQL engine :gear: that powers LGTM.com. For more information, please check out our post on the GitHub blog.

codecov[bot] commented 1 year ago

Codecov Report

Base: 60.38% // Head: 59.87% // Decreases project coverage by -0.51% :warning:

Coverage data is based on head (8d50295) compared to base (c615000). Patch coverage: 45.62% of modified lines in pull request are covered.

:exclamation: Current head 8d50295 differs from pull request most recent head 447a183. Consider uploading reports for the commit 447a183 to get more accurate results

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #594 +/- ## ========================================== - Coverage 60.38% 59.87% -0.52% ========================================== Files 149 153 +4 Lines 7402 7740 +338 ========================================== + Hits 4470 4634 +164 - Misses 2932 3106 +174 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `59.87% <45.62%> (-0.52%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [...ulation/pitop/simulation/virtual\_hardware/pitop.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3ZpcnR1YWxfaGFyZHdhcmUvcGl0b3AucHk=) | `9.09% <8.33%> (-3.04%)` | :arrow_down: | | [...ages/simulation/pitop/simulation/widgets/slider.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3dpZGdldHMvc2xpZGVyLnB5) | `17.56% <17.56%> (ø)` | | | [...ages/simulation/pitop/simulation/widgets/widget.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3dpZGdldHMvd2lkZ2V0LnB5) | `37.03% <37.03%> (ø)` | | | [packages/simulation/pitop/simulation/simulation.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXVsYXRpb24ucHk=) | `49.13% <38.46%> (-1.33%)` | :arrow_down: | | [packages/simulation/pitop/simulation/utils.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3V0aWxzLnB5) | `50.00% <50.00%> (ø)` | | | [packages/simulation/pitop/simulation/sprites.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3Nwcml0ZXMucHk=) | `48.09% <51.89%> (+9.49%)` | :arrow_up: | | [packages/simulation/pitop/simulation/simsprite.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXNwcml0ZS5weQ==) | `41.66% <64.70%> (+4.00%)` | :arrow_up: | | [packages/pma/pitop/pma/light\_sensor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9saWdodF9zZW5zb3IucHk=) | `100.00% <100.00%> (+33.33%)` | :arrow_up: | | [packages/pma/pitop/pma/sound\_sensor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9zb3VuZF9zZW5zb3IucHk=) | `92.85% <100.00%> (+20.12%)` | :arrow_up: | | [packages/simulation/pitop/simulation/events.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL2V2ZW50cy5weQ==) | `100.00% <100.00%> (ø)` | | | ... and [9 more](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/594/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.