pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Set 'number_of_samples' in constructor of ADCBase and subclasses #595

Closed jcapona closed 1 year ago

jcapona commented 1 year ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 year ago

Codecov Report

Base: 60.39% // Head: 60.38% // Decreases project coverage by -0.00% :warning:

Coverage data is based on head (0c3584a) compared to base (4e06cbe). Patch coverage: 66.66% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #595 +/- ## ========================================== - Coverage 60.39% 60.38% -0.01% ========================================== Files 149 149 Lines 7401 7402 +1 ========================================== Hits 4470 4470 - Misses 2931 2932 +1 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `60.38% <66.66%> (-0.01%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [packages/pma/pitop/pma/button.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9idXR0b24ucHk=) | `100.00% <ø> (ø)` | | | [packages/pma/pitop/pma/buzzer.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9idXp6ZXIucHk=) | `100.00% <ø> (ø)` | | | [packages/pma/pitop/pma/encoder\_motor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9lbmNvZGVyX21vdG9yLnB5) | `77.27% <ø> (ø)` | | | [packages/pma/pitop/pma/led.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9sZWQucHk=) | `100.00% <ø> (ø)` | | | [packages/pma/pitop/pma/servo\_motor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9zZXJ2b19tb3Rvci5weQ==) | `67.67% <ø> (ø)` | | | [packages/pma/pitop/pma/adc\_base.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9hZGNfYmFzZS5weQ==) | `57.89% <50.00%> (-3.22%)` | :arrow_down: | | [packages/pma/pitop/pma/light\_sensor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9saWdodF9zZW5zb3IucHk=) | `66.66% <66.66%> (ø)` | | | [packages/pma/pitop/pma/sound\_sensor.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9zb3VuZF9zZW5zb3IucHk=) | `72.72% <66.66%> (+6.06%)` | :arrow_up: | | [packages/pma/pitop/pma/potentiometer.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/595/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvcG1hL3BpdG9wL3BtYS9wb3RlbnRpb21ldGVyLnB5) | `73.33% <100.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.