pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Simulation of Componentables will render components added after starting #602

Closed angusjfw closed 1 year ago

angusjfw commented 1 year ago
Status Ticket/Issue
Ready Ticket

Main changes

Other notes (e.g. implementation quirks, edge cases, questions / issues)

So this works now but it feels not quite right messing with the recreatables _config... probably fine though.

Manual testing tips

codecov[bot] commented 1 year ago

Codecov Report

Base: 59.85% // Head: 59.81% // Decreases project coverage by -0.04% :warning:

Coverage data is based on head (488e1b4) compared to base (78dd869). Patch coverage: 20.58% of modified lines in pull request are covered.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #602 +/- ## ========================================== - Coverage 59.85% 59.81% -0.04% ========================================== Files 155 155 Lines 7811 7829 +18 ========================================== + Hits 4675 4683 +8 - Misses 3136 3146 +10 ``` | Flag | Coverage Δ | | |---|---|---| | unittests | `59.81% <20.58%> (-0.04%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more. | [Impacted Files](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [packages/simulation/pitop/simulation/simsprite.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXNwcml0ZS5weQ==) | `40.90% <5.26%> (-0.76%)` | :arrow_down: | | [packages/simulation/pitop/simulation/simulation.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvc2ltdWxhdGlvbi9waXRvcC9zaW11bGF0aW9uL3NpbXVsYXRpb24ucHk=) | `48.06% <35.71%> (-1.08%)` | :arrow_down: | | [packages/core/pitop/core/mixins/componentable.py](https://codecov.io/gh/pi-top/pi-top-Python-SDK/pull/602?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#diff-cGFja2FnZXMvY29yZS9waXRvcC9jb3JlL21peGlucy9jb21wb25lbnRhYmxlLnB5) | `75.43% <100.00%> (+2.22%)` | :arrow_up: | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top)

:umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.