pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Use zmq.green for gevent compatibility #636

Closed jcapona closed 1 month ago

jcapona commented 1 month ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

-

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 month ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 59.01%. Comparing base (9b663bf) to head (c481160). Report is 7 commits behind head on master.

:exclamation: Current head c481160 differs from pull request most recent head 4f9933e

Please upload reports for the commit 4f9933e to get more accurate results.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #636 +/- ## ======================================= Coverage 59.01% 59.01% ======================================= Files 160 160 Lines 7998 7998 ======================================= Hits 4720 4720 Misses 3278 3278 ``` | [Flag](https://app.codecov.io/gh/pi-top/pi-top-Python-SDK/pull/636/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pi-top/pi-top-Python-SDK/pull/636/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | `59.01% <100.00%> (ø)` | | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.