pi-top / pi-top-Python-SDK

pi-top's Python SDK (pitop package)
Apache License 2.0
27 stars 4 forks source link

Find Dnsmasq IP leases #647

Closed jcapona closed 1 week ago

jcapona commented 2 weeks ago
Status Ticket/Issue
Ready/Hold Ticket

Main changes

Screenshots (feature, test output, profiling, dev tools etc)

[insert screenshots here]

Other notes (e.g. implementation quirks, edge cases, questions / issues)

-

Manual testing tips

-

Tag anyone who definitely needs to review or help

-

codecov[bot] commented 1 week ago

Codecov Report

Attention: Patch coverage is 93.61702% with 3 lines in your changes missing coverage. Please review.

Project coverage is 59.21%. Comparing base (8174e8c) to head (8584b80).

Files Patch % Lines
packages/common/pitop/common/sys_info.py 93.61% 3 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #647 +/- ## ========================================== - Coverage 59.27% 59.21% -0.06% ========================================== Files 160 160 Lines 7998 8033 +35 ========================================== + Hits 4741 4757 +16 - Misses 3257 3276 +19 ``` | [Flag](https://app.codecov.io/gh/pi-top/pi-top-Python-SDK/pull/647/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/pi-top/pi-top-Python-SDK/pull/647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top) | `59.21% <93.61%> (-0.06%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=pi-top#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.