search

pi3d / pi3d_demos

Demos and support files for pi3d (3D graphics python package for the raspberry pi)
Other
71 stars 33 forks source link

Support for skipping subdirectory and images smaller than a certain size #27

Closed CyclistHomeCoder closed 3 years ago

CyclistHomeCoder commented 4 years ago

Hi,

Ia really like the PictureFrame app you have created, thanks!

I have made a modification so I am able to specify a minimum file size and also to be able to skip directories with a certain name. These two options are useful for me who runs it directly on my NAS (that generates a lot of thumbnails).

Would you be interesting in merging my changes or should I maybe fork?

BR

paddywwoof commented 4 years ago

Hi Cyclist, It would be great to share your info but I'm not sure the best way; the app is already bursting at the seams with all the improvements added over the years. Maybe the tidiest way is for you to have your version on github (gitlab etc) and I could put a comment with a link in the PictureFrame file (there are a couple of other major changes that people have done that I ought to do the same with).

CyclistHomeCoder commented 4 years ago

No problem, I created a lightweight fork of the just the picture frame here https://github.com/CyclistHomeCoder/PIcFrame.

paddywwoof commented 3 years ago

Hi, at some point I might try a more comprehensive re-structure of the picture frame code (splitting out the display and control along the lines of https://github.com/helgeerbe/picture_frame probably) and I will bear in mind a mechanism for including ideas such as yours in a reasonably logical way.

In the mean time, hopefully, anyone wanting to do what you did can follow your link. Thanks again.