search

piEsposito / blitz-bayesian-deep-learning

A simple and extensible library to create Bayesian Neural Network layers on PyTorch.
GNU General Public License v3.0
918 stars 107 forks source link

GPU compatible if bias is set to zero conv2d fixed #71

Closed Hannan4252 closed 3 years ago

Hannan4252 commented 3 years ago

Bug for conv2d if bias is set to False cus bias then torch.zeros were generated at cpu while other parameters were at cuda.... Now fixed only for conv2d...

piEsposito commented 3 years ago

Hello @Hannan4252 and thank yo so much for contributing to BLiTZ.

On your #71 you fix this bug for conv1d, and not 2d pr 3d. Is that right?

Hannan4252 commented 3 years ago

@piEsposito , yes its for conv1d but if you want me to also fix for 2d and 3d i can do that and pull a request ... and thanks a lot for the great lib :)

piEsposito commented 3 years ago

@Hannan4252 if you have the time and will to do the fix for the 2d and 3d layers, I would be glad to merge it onto the PR.

Hannan4252 commented 3 years ago

@piEsposito bug is fixed :)

piEsposito commented 3 years ago

Merged, closing this issue.