Closed andrechalom closed 8 years ago
Sure. I'll try to keep the new names as mnemonic and informative as time
and history
are. Maybe time_ellapsed
and trajectories
?
Also, we have to change the name of ls.m
that can conflict with ls
S3 methods.
I will hold this issue while waiting for the open PRs to be merged.
Changing the following:
We could change things like diagPlots() to diag_plots() - changed camelCase to underscores, as it is more readable. But I don't think that's necessary.
I'm leaving Init_Community and GillesComFromFile/GillesComToFile as uppercase because these are very special function in the way that they handles directly with the underlying constructor.
All of these changed already on master branch.
OK, can we close this?
Ok! Can you merge into dev please?
You have already merged this changes on d090452
Currently, we have the functions
time
andhistory
, which clash with stats::time and stats::history. We need to come up with better names to rename those functions and avoid namespace clashes.Also, it is a good design practice to determine standard naming conventions for the functions and othe relevant objects in the package.