piMoll / swissgeodownloader

QGIS Plugin for downloading swiss geodata
https://pimoll.github.io/swissgeodownloader/
GNU General Public License v2.0
9 stars 2 forks source link

Some datasets geographically restricted #5

Closed thymaro closed 2 years ago

thymaro commented 2 years ago

Congrats on the plugin. It's great. Getting the list of available datasets works again, that's nice. The following is not to complain or anything like that, I'm just asking to understand and to report bugs or what seems like bugs.

There seem to be missing datasets or timestamps. Take swissalti3d and the region between Cham and Horgen. In the plugin, we can choose between datasets from 2019 and 2021, but not 2020. It seems there are datasets from 2020 that might fill (some of) the holes in the (combination of) the two other datasets. Can you confirm this on your end?

piMoll commented 2 years ago

Hi thymaro Thanks very much for this question. There is indeed something strange going on.

To fill in the dataset properties in the UI (timestamps, formats, etc,) I request dataset properties from https://data.geo.admin.ch/api/stac/v0.9/collections/ch.swisstopo.swissalti3d The dataset properties tell me that there are 2 timestamps: 2019 and 2021. But when requesting data for the area between Cham and Horgen I get data for at least 3 timestamps (2019, 2020, 2021). So the properties of the dataset seem to be wrong.

I will inform swisstopo about this, maybe they can fix it.

Also, I think it would make sense to add an option "all" for timestamps in the next release. Lots of people just want to download all available data.

piMoll commented 2 years ago

A guy at swisstopo has informed me that the temporal extent of the dataset describes an interval, not a list of available timestamps.

This means that my implementation of the timestamp selection is wrong and you can't get timestamps in between 2019 and 2021. Sorry about that. This issue concerns swissalti3d and in general all datasets that have more than 2 timestamps.

I will fix this in the next release and probably do some reorganization of the UI parts, remove the dataset properties and instead add file filters. I think this makes much more sense and will lead to less problems in the future.

Thanks for spotting this!

thymaro commented 2 years ago

ah, good point! Let's see what they can say about that.

"all" for timestamps is useful for time series, but an option "latest" or "newest" would make more sense in my case, because I just want the newest, freshest, shiniest data, although I don't know how widespread that need is. I would have guessed pretty widespread, but I might be wrong.

Am 09.02.2022 um 09:27 schrieb Pi Moll:

Hi thymaro Thanks very much for this question. There is indeed something strange going on.

To fill in the dataset properties in the UI (timestamps, formats, etc,) I request dataset properties from https://data.geo.admin.ch/api/stac/v0.9/collections/ch.swisstopo.swissalti3d The dataset properties tell me that there are 2 timestamps: 2019 and

  1. But when requesting data for the area between Cham and Horgen I get data for at least 3 timestamps (2019, 2020, 2021). So the properties of the dataset seem to be wrong.

I will inform swisstopo about this, maybe they can fix it.

Also, I think it would make sense to add an option "all" for timestamps in the next release. Lots of people just want to download all available data.

— Reply to this email directly, view it on GitHub https://github.com/piMoll/swissgeodownloader/issues/5#issuecomment-1033481838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AF2KCHG3ND7U55HLNK5DKQ3U2IQOPANCNFSM5NXEZ7OQ. Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

thymaro commented 2 years ago

sorry, didn't see your latest reply! They already answered, that's great.

Hey, cool, I'm eager to see what you will do with it next. I wish I could help you more on the technical side of things, but my coding abilities aren't up to par, yet.