pia-foss / desktop

Private Internet Access - Desktop VPN Client for Windows/macOS/Linux
Other
279 stars 52 forks source link

Windows: Wireguard Connection Fails #53

Open Silvenga opened 1 year ago

Silvenga commented 1 year ago

Describe the bug

I reported this to Help desk, but I wanted to make sure it got to a developer.

Symptoms include:

Unable to create Wintun interface: Error creating interface: No driver for device "Wintun" installed

Reinstalling Wintun via the Client interface has no effect.

Expected behavior

If the HKEY_LOCAL_MACHINE\SOFTWARE\Wintun key is present the pia-wintun.msi MSI appears to no-op. It appears that this may occur with using an old version of the MSM provided by WireGuard (I have not confirmed this was been fixed, I just lost where the code moved to).

This appears to mainly occur due to the check done in the MSM: https://git.zx2c4.com/wintun/tree/installer/msi.c?id=27e4d334fcd6b8d706fb0921fe501812622ca988#n95

Normally MSI should be able to repair this problem, but it appears the MSI is using CustomAction's with side-effects preventing normal healing operations (and possibly cleanup on uninstallation).

It's likely dangerous to modify the MSM. I would propose one of the following self-contained solution:

Observed on: