search

pia-foss / manual-connections

Scripts for manual connections to Private Internet Access
MIT License
620 stars 170 forks source link

Option to only generate WG config file i.s.o. connecting. #171

Closed RoboMagus closed 1 year ago

RoboMagus commented 1 year ago

Implements feature requested in #168 (Just for WG though).

This PR adds ENV variables PIA_CONNECT and PIA_CONF_PATH that are default set to keep the script operating as before, but can be overwritten by the user to disable automatically opening the VPN connection, and to set a default output path for the created wireguard config.

RoboMagus commented 1 year ago

@kp-andre-flemming could you please take a look? (Assuming you're the one to ask).

Likely some implementation details should be changed, but it'd be great to have just config generation available through these scripts.

kp-andre-flemming commented 1 year ago

Hey,

sorry for the response here. Will have a look later this week.

RoboMagus commented 1 year ago

No problem, thanks for the update. As long as I know it's on the radar 😉

kp-andre-flemming commented 1 year ago

Looks good so far, but please add a short note about the two new environment variables to the README, I propose the section "Automated Setup" and here "Connecti to Wireguard" https://github.com/pia-foss/manual-connections/blob/master/README.md#automated-setup