search

pia-foss / mobile-android-legacy

Private Internet Access - Android VPN Client
MIT License
38 stars 14 forks source link

PIA-634: Android Logout Add e2e Coverage #39

Closed kp-ruth-o closed 1 year ago

kp-ruth-o commented 1 year ago

Purpose

This PR is to add logout e2e tests to our code. It covers checking for 2 important features we have for PIA, which is Dedicated IP and Protocol selection.

The expected results is that once user has logout from the android mobile application and log back in again, the previously selected protocol that is not set by default will no longer be selected. Same goes for Dedicated IP, the DIP entered by the user once logout will be removed.

kp-aldo-pedromingo commented 1 year ago

Commits: a7bf33c050fb8809260a158e01097280eb6ffeb0 and d80a119df8df61d0eef59011837134c7c38623fb appear to be partially signed. This might be an issue, as the PR sniffer will block the merge of the PR.

@kp-andrei-madescu it looks like your commits are not being correctly signed?

A solution for this could be to do a rebase and squash the faulty commits into another.

kp-andrei-madescu commented 1 year ago

Commits: a7bf33c and d80a119 appear to be partially signed. This might be an issue, as the PR sniffer will block the merge of the PR.

@kp-andrei-madescu it looks like your commits are not being correctly signed?

A solution for this could be to do a rebase and squash the faulty commits into another.

Not sure why those commits are "partially signed". However, in terms of merging the repo is configured to automatically squash all commits when merging, which might clear this issue at that point. Nevertheless, if this causes issues I will look into it and manually fix it.

kp-ruth-o commented 1 year ago

Commits: a7bf33c and d80a119 appear to be partially signed. This might be an issue, as the PR sniffer will block the merge of the PR. @kp-andrei-madescu it looks like your commits are not being correctly signed? A solution for this could be to do a rebase and squash the faulty commits into another.

Not sure why those commits are "partially signed". However, in terms of merging the repo is configured to automatically squash all commits when merging, which might clear this issue at that point. Nevertheless, if this causes issues I will look into it and manually fix it.

Let me try merging this and see if there's an issue with the partially signed 🙏