search

pianobooster / PianoBooster

A MIDI file player/game that displays the musical notes and teaches you how to play the piano.
Other
412 stars 78 forks source link

A feature to go back to the start of current measure #292

Open mark-Dutton opened 3 years ago

mark-Dutton commented 3 years ago

Hi, Is there a feature that lets you snap back to the beginning of a measure/bar. i.e. if I am on bar 2 and stuff up a note I can just click a button to snap to the start of bar 2.

Also I am a computer science student and am keen on contributing to some GitHub projects and I really love this software. Recently got a keyboard with a midi adaptor and am playing along to heaps of songs that I'm trying to learn :)

Maybe I could have a crack at implementing something and submitting a pull request for this feature?

louis-barman commented 3 years ago

Ok Great, I was REALLY hoping someone would come forward to help out. The only problem is I am extremely busy with other things in my personal life at the moment and can give very little time to this for the next few weeks after that it should be much better.

So really this type of request should be moved over to the develop forum please see http://piano-booster.2625608.n2.nabble.com/Piano-Booster-Development-f2625691.html so please post any replies to this thread over there thanks.

There are other higher priority things (in my mind) you could work on at the moment.

  1. There is the wip/opengl branch that needs completing at the moment as PB does not work on 4K screens and it also needed for older PC. It upgrads to use QOpenGLWidget instead of the obsolete QGLWidget in QT5. It is fairly obvious what need fixing when you resize the window. Please keep the behaviour and sizes much the same for now.
  2. Then there is the wip/metronome also needs finishing please see this thread for the details: https://github.com/pianobooster/PianoBooster/issues/71 A ui is needed. we would probably start with pencil sketches of the UI
  3. There is a http://piano-booster.2625608.n2.nabble.com/Accuracy-bar-td7572921.html Showing a percentage score at the end of playing a song. Years ago i created GuiHighScoreWindow.ui but that is far as I got . A percentage score could be created from detecting and counting up all the right and wrong notes played. I think the GuiHighScoreWindow.ui should be renamed to something like GuiSkillLevelResults.ui. This is quite a fun task that should not be too hard. Also I already have code to record and then replay the piece of music you just played. Again we would probably start with pencil sketches of the UI
  4. If you want to implement your suggestion then please go ahead. But for now please just add a keyboard shortcut. Maybe for now using the '<' and '>' keys. I am thinking about how to change the UI for this idea. I want to keep the UI very simple and uncluttered that children can easily use. You might need to search for looping in the source code. MIDI is not like an audio file. For complicated reasons to skip back two bars you need first rewind to the very beginning and play the midi file at high speed without making any sounds until you reach the right point. This is how the play from bar feature works.
  5. Adding a current dispaly PBM display please see: https://github.com/pianobooster/PianoBooster/issues/70 this is a really easy change.

Again please reply in a new issue in the develop forum. Please let me know which of those five items you might like to work on. Thanks for contacting me first. it makes things much easier.

Finally if you or anyone else would like to review my code before I make a commit then please let me know. I find code reviews very helpful.