picandocodigo / emacs.sexy

Emacs.sexy
Other
96 stars 20 forks source link

Fixed padding in navbar to suit all screen sizes #33

Closed DylanEStone closed 5 years ago

DylanEStone commented 5 years ago

As shown in the following picture, when the current page is being viewed in some aspect ratios, the navbar's formatting is completely ruined. example

These edits reduce the size of the padding that caused this, effectively fixing the nav bar for every possible screen size as shown in the picture below. afterchanges

picandocodigo commented 5 years ago

Hi @DylanEStone, thank you very much for this contribution!

I'm closing the other PR, and merging this one in. Thanks again! :+1:

DylanEStone commented 5 years ago

Fernando,

I'm glad to help, FYI that was my first pull request so it felt great so see it merged when I checked.

I've been a free software user for quite some time, and it is satisfying to feel comfortable enough to contribute back to the community.

I love the website by the way, I've transitioned from vim to emacs over the past year, and that hand drawn guide on your page was very helpful getting started.

On Thu, May 16, 2019, 2:08 AM Fernando Briano notifications@github.com wrote:

Hi @DylanEStone https://github.com/DylanEStone, thank you very much for this contribution!

I'm closing the other PR, and merging this one in. Thanks again! 👍

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/picandocodigo/emacs.sexy/pull/33?email_source=notifications&email_token=AF6F76J26A7LB6RPGRVU4XLPVUQCFA5CNFSM4HNJSICKYY3PNVWWK3TUL52HS4DFVREXG43VMVBW63LNMVXHJKTDN5WW2ZLOORPWSZGODVRFYBQ#issuecomment-492985350, or mute the thread https://github.com/notifications/unsubscribe-auth/AF6F76MMTRKEDZKNHWXSCELPVUQCFANCNFSM4HNJSICA .

picandocodigo commented 5 years ago

That's amazing, congratulations on your first Pull Request! :tada: Hopefully the first of many to come :raised_hands:

Thank you for your comment, I know how you feel! I love the feeling of seeing one of my pull requests being merged. That's part of what free software is all about :smiley:

On top of that, knowing that the website helped you transitioning from Vim to Emacs makes me very happy!