parameters are not properly quoted for windows

[GoogleCodeExporter]

In svn r115, example1.py does not render properly on windows:
parameters with space characters are not escaped thus the command fail.
Attached is a patch to let popen do escaping of parameters.
While it is better, this is not quite correct since with this patch,
legends are rendered as "Maximum Allowed" (with double quotes in the png)

Original issue reported on code.google.com by denis.fortin@vitecmm.com on 24 Apr 2009 at 6:42

Attachments:

• parameter_quoting.patch

[GoogleCodeExporter]

New patch which fix the legend issue.

Original comment by denis.fortin@vitecmm.com on 27 Apr 2009 at 1:28

Attachments:

• parameter_quoting2.patch

[GoogleCodeExporter]

Thanks Dennis!

Applied patch in r118.

Original comment by duncan.m...@gmail.com on 2 Jul 2009 at 4:41

• Changed state: Fixed

[GoogleCodeExporter]

I'm re-opening this bug, because some of the changes made here had to be 
reverted to
support the RRDTool Python bindings.

The Python bindings support needs to be tested on Windows. If all the unit tests
pass, we can close this bug.

Original comment by duncan.m...@gmail.com on 27 Oct 2009 at 9:04

• Changed state: Started

[GoogleCodeExporter]

I'll leave this ticket open for a week; if I don't hear anything back from 
Windows
users, I'll assume things are okay and close it.

However, if problems to surface after that, users should feel free to open a 
ticket
(or reopen this one).

Original comment by duncan.m...@gmail.com on 28 Oct 2009 at 6:42

[GoogleCodeExporter]

The problem is fixed for windows on latest trunk.

Original comment by denis.fortin@vitecmm.com on 29 Oct 2009 at 10:04

[GoogleCodeExporter]

Great. Thanks for the  note!

Original comment by duncan.m...@gmail.com on 29 Oct 2009 at 4:45

• Changed state: Fixed

[GoogleCodeExporter]

Original comment by duncan.m...@gmail.com on 29 Oct 2009 at 8:41

• Changed state: FixCommitted