picatz / goldengirl

✨ All that shimmers is gold!
MIT License
3 stars 0 forks source link

docker installation #7

Closed picatz closed 6 years ago

picatz commented 6 years ago

Need to add docker installation to Vagrantfile

picatz commented 6 years ago

Fixed in https://github.com/picatz/goldengirl/commit/6061f1302087f37b9f6d461c518e24ae1648ab43

picatz commented 6 years ago

This is probably using a version of docker we don't want.

picatz commented 6 years ago

Todo

Follow these instructions: https://docs.docker.com/engine/installation/linux/docker-ce/centos/

picatz commented 6 years ago

Hopefully finally resolved in https://github.com/picatz/goldengirl/commit/6af6f4f2bdcab872bd17e6723d3dc71bb2f98afa

picatz commented 6 years ago

Re-opening to possible address issues brought up in the official docs: https://docs.docker.com/engine/installation/linux/linux-postinstall/

picatz commented 6 years ago

Since the impact I see is mostly just not having to run sudo, I don't really think the extra installation steps detailed in the docs really add anything else to what we currently have.