search

picatz / terraform-google-nomad

📗 Terraform Module for Nomad clusters with Consul on GCP
https://registry.terraform.io/modules/picatz/nomad/google
MIT License
78 stars 16 forks source link

Consul configuration defines unused options in server and client #53

Closed picatz closed 1 year ago

picatz commented 2 years ago

Client agents do not need to enable connect, this is only used on servers:

Enabling Connect requires changing the configuration of only your Consul servers (not client agents).

https://github.com/picatz/terraform-google-nomad/blob/0db159e7c90367553c3c9b61c3a892418d686e36/packer/configs/consul/client.hcl#L30-L32

Servers do not need to enable the gRPC port, this is only used on clients:

https://github.com/picatz/terraform-google-nomad/blob/0db159e7c90367553c3c9b61c3a892418d686e36/packer/configs/consul/server.hcl#L17

There might be others, but these should definitely be removed.

lordsonfernando commented 2 years ago

Hi,I would like to contribute

picatz commented 2 years ago

👋 Hello @lordsonfernando, PRs are welcome!