search

piccolbo / Pweave

Pweave is a scientific report generator and a literate programming tool for Python. It can capture the results and plots from data analysis and works well with numpy, scipy and matplotlib.
http://mpastell.com/pweave
Other
1 stars 0 forks source link

Scipy pin travis #3

Closed fgregg closed 5 years ago

fgregg commented 5 years ago

This PR depends on #2 and fixes the tests by installing a release candidate version of scipy that will not cause numpy to warn about an upcoming deprecation. This warning is bleeding into some pweaved output and causing failing tests.

piccolbo commented 5 years ago

I have two questions: this PR passes without #2. Why do you say in the comments this depends on #2 and if so, why don't you just grab the commits you need and move them here? The other small issue is that you turned off email notifications for everyone, en passant. I doubt that's necessary to pass tests and I fine them useful in other projects. Not putting my foot down on this one, a matter of preference.

fgregg commented 5 years ago

This feature branch forks off the branch in #2. You can just accept this one, or you can accept the branch in #2, or you can do neither. or both. If you accept this one, it'll automatically close #2.

I didn't intent to turn off email notification. I'll fix that in #2, and rebase that here.