piccolo-orm / piccolo

A fast, user friendly ORM and query builder which supports asyncio.
https://piccolo-orm.com/
MIT License
1.41k stars 89 forks source link

1005 CockroachDB - enable array tests #1012

Closed dantownsend closed 3 months ago

dantownsend commented 3 months ago

Related to https://github.com/piccolo-orm/piccolo/issues/1005

Using the latest versions of CockroachDB (v24.1.0), and asyncpg (0.29.0), array queries are very slow.

The SQL that Piccolo generates is very simple, so I don't think it's anything to do with Piccolo (also, these queries run fine on Postgres).

Previously, we had a bunch of array tests disabled for CockroachDB. These tests now pass, but they're just very slow. For that reason, we won't run them in the CI.

In the future we'll revisit this when newer versions of CockroachDB and asyncpg are released, or when we support alternative database adapters (e.g. psycopg3).