search

piccolo-orm / piccolo

A fast, user friendly ORM and query builder which supports asyncio.
https://piccolo-orm.com/
MIT License
1.46k stars 91 forks source link

Update ASGI frameworks #801

Closed dantownsend closed 1 year ago

dantownsend commented 1 year ago

Starlite has now been renamed to litestar (https://github.com/litestar-org/litestar), so we should update the docs accordingly.

Also, the goals of the Xpresso project have changed:

So where does that leave Xpresso? It's going to stay around, but it's less likely to become a stable production ready framework: it can provide more value to the community as an exprimental proving ground for ideas than as yet another "production ready" web framework.

We should probably remove it as a supported ASGI framework. It's a shame because it's a cool framework, but we're running integration tests against it on every commit and we should save the overhead if possible.

cc @sinisaos What do you think?

sinisaos commented 1 year ago

Starlite has now been renamed to litestar (https://github.com/litestar-org/litestar), so we should update the docs accordingly.

I saw that Starlite changed its name to Litestar a few days ago and I was already thinking about changing the ASGI template to use the new name. I can do it if you agree, as we just need to change the imports to use the new name as nothing else changes and everything still works with the old name (I just tried it yesterday).

Also, the goals of the Xpresso project have changed:

So where does that leave Xpresso? It's going to stay around, but it's less likely to become a stable production ready framework: it can provide more value to the community as an exprimental proving ground for ideas than as yet another "production ready" web framework.

We should probably remove it as a supported ASGI framework. It's a shame because it's a cool framework, but we're running integration tests against it on every commit and we should save the overhead if possible.

I agree with you. Would it be nice if we also notify author of Xpresso that we will be making these changes?

dantownsend commented 1 year ago

I saw that Starlite changed its name to Litestar a few days ago and I was already thinking about changing the ASGI template to use the new name. I can do it if you agree, as we just need to change the imports to use the new name as nothing else changes and everything still works with the old name (I just tried it yesterday).

Yeah, if we could update it that would be great.

As for Xpresso, removing it isn't a high priority, so we'll just do it when we have time.

sinisaos commented 1 year ago

@dantownsend I've already made the changes (removed Xpresso and updated Starlite->Litestar) and I'm just checking to see if everything works. During the day I will do a PR.

dantownsend commented 1 year ago

@sinisaos Thanks!

dantownsend commented 1 year ago

Resolved by https://github.com/piccolo-orm/piccolo/pull/802