search

piccolo-orm / piccolo_admin

A powerful web admin for your database.
https://piccolo-orm.com/ecosystem/
MIT License
299 stars 35 forks source link

fix rate limiting with `TestClient` #365

Closed dantownsend closed 4 months ago

dantownsend commented 4 months ago

Resolves https://github.com/piccolo-orm/piccolo_admin/issues/364

dantownsend commented 4 months ago

More random linter failures ...

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (7f3383b) 93.38% compared to head (c5b1989) 93.40%.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## master #365 +/- ## ========================================== + Coverage 93.38% 93.40% +0.01% ========================================== Files 5 5 Lines 363 364 +1 ========================================== + Hits 339 340 +1 Misses 24 24 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

dantownsend commented 4 months ago

I was going to disable rate limiting for the tests, but it wasn't something I wanted long term. So for now, it's easiest just to pin FastAPI to an older version for the tests. When a new version of Starlette / FastAPI is released in the future, we'll remove the version pin.

dantownsend commented 4 months ago

Merged this in, because it blocks any other work on Piccolo Admin.