search

piccolo-orm / piccolo_admin

A powerful web admin for your database.
https://piccolo-orm.com/ecosystem/
MIT License
299 stars 35 forks source link

Translation Issue with Bulk Update Button #375

Closed jrycw closed 3 months ago

jrycw commented 3 months ago

When attempting bulk editing for updates and deletes, it seems that the bulk update button is not being translated properly, unlike the bulk delete button which functions correctly. I've tested switching to other languages, and it appears that this issue is not specific to any particular language.

English

eng

Traditional Chinese (for instance):

zh_tw

jrycw commented 3 months ago

It's possible that the issue stems from the following code: https://github.com/piccolo-orm/piccolo_admin/blob/aa8db7225b412f85f0a247c86160f36b8993134e/admin_ui/src/views/RowListing.vue#L23

sinisaos commented 3 months ago

@jrycw Yes, you're right. That line should be

<span>
    {{ $t("Update") }}
    {{ selectedRows.length }} {{ $t("rows") }}
</span>
dantownsend commented 3 months ago

Thanks for reporting this. I've added a PR with the fix suggested by @sinisaos.