piccolo-orm / piccolo_theme

A clean and modern Sphinx theme.
https://piccolo-theme.readthedocs.io/en/latest/
MIT License
93 stars 10 forks source link

Add Playwright tests #39

Open dantownsend opened 2 years ago

dantownsend commented 2 years ago

We use Playwright to test other UI projects in the Piccolo ecosystem (see Piccolo Admin).

Playwright is a E2E / UI testing framework.

Phase 1

Approximate time needed: 1 to 2 hours, depending on existing knowledge of Playwright.

Phase 2

Can be done in a separate PR.

Approximate time needed is 1 to 2 hours, depending on knowledge of GitHub actions.

mikebarr24 commented 2 years ago

Hey @dantownsend. Would it be OK if I worked on this issue?

dantownsend commented 2 years ago

@mikebarr24 Yes, of course - would be great 👍

mikebarr24 commented 2 years ago

@dantownsend Thank you! I'm new to this project and a lot of what I will be doing will be new to me. If you are looking for a fast fix to this, I'm happy to drop this.

Otherwise, I'm looking forward to getting involved!

dantownsend commented 2 years ago

@mikebarr24 There's no pressure - just tackle it in your own time. Hopefully it's an interesting one for you. I find Playwright quite exciting, and am introducing it into all of my projects.

mikebarr24 commented 2 years ago

Hey @dantownsend. You're right! Playwright is a great package to have been introduced to!

I'm having some issues with the script file. I can't get the server to close after tests have run. Not sure if you're aware of any fix for this. I've created a PR anyway for you to have a look at. Happy to take on any feedback.

Thanks