search

piccolo-orm / targ

Python CLI using type hints and docstrings.
https://targ.readthedocs.io/en/latest/index.html
MIT License
20 stars 2 forks source link

Add MANIFEST.in #10

Closed thewchan closed 2 years ago

thewchan commented 2 years ago

Can we add a manifest file here? https://packaging.python.org/guides/using-manifest-in/

dantownsend commented 2 years ago

The project doesn't contain much package data, just a py.typed file, which is added here:

https://github.com/piccolo-orm/targ/blob/8660cbc42b2758e58ae3771a2d398cf5fbddfe37/setup.py#L36

Are there any other reasons for a MANIFEST.in file?

thewchan commented 2 years ago

I'm in the process of adding this to conda-forge.org/; and a MANIFEST.in file helps greatly with building the binaries (e.g. adding in the requirement.txt file) I can patch it myself downstream but it's better to add it upstream here. No worries if it's too much hassle

dantownsend commented 2 years ago

@thewchan I can add it - no problem. I was just wondering the reason for it.

thewchan commented 2 years ago

Thanks so much, I appreciate it!

thewchan commented 2 years ago

Once this is pushed as a new release to PyPI I will resume trying to get the package to Conda forge

dantownsend commented 2 years ago

@thewchan I've created a PR for it. Is that all you need?

thewchan commented 2 years ago

I believe so, if I run into problems again I'll come back for help. Thanks so much 👍

dantownsend commented 2 years ago

No worries, thanks