search

piccolo2d / piccolo2d.java

Structured 2D Graphics Framework
http://piccolo2d.org
Other
51 stars 14 forks source link

Invisible PClips are reported to be picked by InputEventHandler #234

Closed mro closed 9 months ago

mro commented 9 years ago

Originally reported on Google Code with ID 234

I noted in Issue 113, we added a guard in PNode.fullPick() to only proceed if the node
is visible. PClip duplicates PNode.fullPick() to support the clipping behavior.

The easy workaround is to override PClip and reintroduce the guard, but I wanted to
get this out as an minor issue, b/c it the changed behavior threw me when I converted
a PNode to a PClip.

Should we make PClip behave like PNode in this regard? Should we introduce a protected
method in PNode so that PClip doesn't have to override the entire PNode's fullPaint()
method just to change one line? I recommend we do something like this in next major
version of Piccolo (don't want to change PClip's behavior for a minor version).

Reported by atdixon on 2011-12-28 21:29:07

mro commented 9 years ago 
Let me clarify, as my first paragraph above was unclear... 

PClip.fullPick() doesn't have the getVisible() check that PNode.fullPick() has, so
PClip nodes are picked even if they are invisible.

Reported by atdixon on 2011-12-28 21:30:27

mro commented 9 years ago

Reported by heuermh on 2012-08-31 20:24:01

mro commented 9 years ago

Reported by heuermh on 2013-11-26 21:11:16