PStyledText too closed for extension in derivations

mro commented 9 years ago

Originally reported on Google Code with ID 261

I needed support for dotted underlines in a PStyledText but wasn't able to add appropriate
functionality. In fact it would have been quite easy to add the functionality in a
derived class if PStyledText were a bit more open for overrides in derivations.

Please consider the attached patch as an improvement. It does not change the existing
functionality but just opens it a bit by
- Making some methods protected instead of private
- Separating some code blocks in protected template methods
- Adding getters to inner classes
- Encapsulating the construction of SegmentInfo in a method to allow derived classes
providing an extended type instead

Reported by jlessner@gmx.de on 2014-12-29 19:37:02

Attachment: PStyledText.java.patch

mro commented 9 years ago

Reported by heuermh on 2014-12-29 21:44:06

Status changed: Accepted
Labels added: Type-Enhancement, Priority-High, Effort-Medium, OpSys-All, Toolkit-Piccolo2D.Java, Component-Extras

mro commented 9 years ago

Reported by heuermh on 2014-12-29 23:39:38

Labels added: Milestone-3.0.1

mro commented 9 years ago

Patch applied in revision 1273, thanks!

Please review and if looks ok, mark as Status: Verified

Reported by heuermh on 2014-12-30 03:46:33

Status changed: Fixed

piccolo2d / piccolo2d.java

PStyledText too closed for extension in derivations #261