piceaTech / node-gitlab-2-github

Migrate Issues, milestones etc from gitlab to github
MIT License
547 stars 133 forks source link

Feature: transfer label descriptions #160

Closed alystair closed 1 year ago

alystair commented 1 year ago

image

alystair commented 1 year ago

Note the only major potential edge case I haven't accounted for is if there is a difference between maximum description length between the two - never bothered checking. Assuming the worst - If anyone ever complains you can just trim the description length and output a warning/notice to CLI ¯\_(ツ)_/¯

Edit: There was, see below. Fixed :)

alystair commented 1 year ago

Hrm, actually looking at it now - it seems some label creations are failing silently

alystair commented 1 year ago

LOL it's failing for the exact edge case I predicted - the label description length on GitHub is much shorter.

alystair commented 1 year ago

Ok this is in a great place now, I added a trimOversizedLabelDescriptions boolean setting, when false (default) oversized descriptions are excluded, otherwise they are trimmed to 100 characters. Either way a warning is shown.

image

Oh yeah, I also added some static color consts - so you can throw those into your various console notices to spruce up the coloring to make it easier to see issues :)

alystair commented 1 year ago

Getting a crash, not ready yet... failing on emojis in description.... guh. image

alystair commented 1 year ago

OK, all fixed up and ready to go! 👍

spruce commented 1 year ago

Thanks :)