search

pichalite / nodebb-theme-slick

Slick theme for NodeBB
MIT License
10 stars 35 forks source link

[v1.3.8] Mark as Read for Unread is broken #51

Closed Brutus5000 closed 3 years ago

Brutus5000 commented 3 years ago

I just updated my NodeBB to the latest official release (1.16.2) and therefore the Slick Theme got upgraded to v1.3.8.

Now the "Mark all as read" feature in the Unread section is no longer working.

Before I click on it it looks like this: image

As soon as I click on "Mark as Read" the "All categories" combobox changes to some weird out of place combobox: image

And clicking on "Mark as Read" -> "All" no longer does anything (just refreshes the page): image

Any chance of getting a fix for that on the release branch < 1.17? :heart: I'd like to avoid installing beta releases.

I see no errors in the JS console or on the network.

In case you want to see it for yourself: The forum is https://forum.faforever.com but you'd need to register first on www.faforever.com because of single sign on.

rgigante commented 3 years ago

I confirm the issue and second @Brutus5000 's request. we would like to see this fixed for 1.16.x.

barisusakli commented 3 years ago

https://github.com/pichalite/nodebb-theme-slick/commit/1f1b08586251296f6e22777634c70a506e6fa2dc latest slick should fix this issue