search

pichalite / nodebb-theme-slick

Slick theme for NodeBB
MIT License
10 stars 35 forks source link

Profile Changes Not Saving #53

Closed skeddles closed 3 years ago

skeddles commented 3 years ago

When I go to edit profile, and change my full name, about me, signature, etc, then click save, I get the success popup.

But then when I hard refresh the page, or go to my profile page, you can see that the fields have not changed.

I've tried it many times, and it never seems to save.

If I switch to the persona theme and edit my profile, I get the same popup, but the changes DO save.

I've reinstalled the theme, made sure it's the latest version (1.4.6), and switched back between persona and slick multiple times, and persona always works and slick always doesn't.

skeddles commented 3 years ago

I looked at the requests the theme made:

this is the request made when saving the profile from slick firefox_2021-05-15_13-10-29

this is the request made when saving the profile with persona firefox_2021-05-15_13-10-38

I think it's because the <input>s are missing names, and the form is missing component="profile/edit/form"

skeddles commented 3 years ago

opened a pull request

barisusakli commented 3 years ago

https://github.com/pichalite/nodebb-theme-slick/pull/54