Feature Request - use npm packaged flow

pichillilorenzo / JavaScriptEnhancements

JavaScript Enhancements is a plugin for Sublime Text 3. It offers not only a smart javascript autocomplete but also a lot of features about creating, developing and managing javascript projects (real-time errors, code refactoring, etc.).

MIT License

638 stars 41 forks source link

Feature Request - use npm packaged flow #44

Closed bitschaser closed 6 years ago

bitschaser commented 6 years ago

It seems it is not possible to use project-level flow binary. Or am I missed something?

pichillilorenzo commented 6 years ago

Having a different version of flow could cause errors to my plugin at API-level (the plugin could not work properly) because some flow API could have been changed among the different versions! For example the output coming from a CLI command could be different or the command itself could be changed in an other way. What do you think about that?

bitschaser commented 6 years ago

I think there should be user-defined (maybe non-default) option to enable project-level flow binary. Flow-s internal things changes much more often than external cli ones.

pichillilorenzo commented 6 years ago

@speedboat lol, I had already added this feature! Sorry! Just change the flow_cli_custom_path on the project_settings.json file. See here: https://github.com/pichillilorenzo/JavaScriptEnhancements/wiki/Project-settings