pichillilorenzo / flutter_inappwebview

A Flutter plugin that allows you to add an inline webview, to use a headless webview, and to open an in-app browser window.
https://inappwebview.dev
Apache License 2.0
3.29k stars 1.62k forks source link

forceDark: themeProvider.isDarkMode ? ForceDark.AUTO : ForceDark.OFF, doesn't work #1623

Closed ayushkadbe closed 1 month ago

ayushkadbe commented 1 year ago

Device information: Doctor summary (to see all details, run flutter doctor -v): [✓] Flutter (Channel stable, 3.7.11, on Parrot OS 5.2 (Electro Ara) 6.0.0-12parrot1-amd64, locale en_IN) [✓] Android toolchain - develop for Android devices (Android SDK version 33.0.2) [✓] Chrome - develop for the web [✓] Linux toolchain - develop for Linux desktop [✓] Android Studio (version 2021.3) [✓] VS Code (version 1.77.3) [✓] Connected device (2 available) [✓] HTTP Host Availability

Description

//WebView return InAppWebView( initialUrlRequest: URLRequest(url: widget.webViewModel.url), initialSettings: InAppWebViewSettings( forceDark: themeProvider.isDarkMode ? ForceDark.AUTO : ForceDark.OFF, allowsInlineMediaPlayback: true, preferredContentMode: UserPreferredContentMode.DESKTOP, ),

//Dark Theme final ThemeData darkTheme = ThemeData( primaryColor: Colors.green, colorScheme: ColorScheme.fromSwatch().copyWith(secondary: Colors.blue, brightness: Brightness.dark), // other properties );

ForceDark.AUTO doesn't force websites opened into dark mode. For example google.com

Expected behavior:

Current behavior:

Steps to reproduce

  1. This
  2. Than that
  3. Then

Images

Stacktrace/Logcat

github-actions[bot] commented 1 year ago

👋 @ayushkadbe

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

Manuito83 commented 1 year ago

Is ForceDark not deprecated?

Actually, there's a problem now where getForceDark() returns getForceDark() is a no-op in an app with targetSdkVersion>=T. Edit: it seems just to be a confirmation message according to the documentation.

github-actions[bot] commented 1 month ago

This issue is stale and has been automatically closed because it has been open for more than 365 days with no activity. Please reopen a new issue if you still have it.

github-actions[bot] commented 1 week ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug and a minimal reproduction of the issue.