search

pichillilorenzo / flutter_inappwebview

A Flutter plugin that allows you to add an inline webview, to use a headless webview, and to open an in-app browser window.
https://inappwebview.dev
Apache License 2.0
3.01k stars 1.33k forks source link

bump js version from 0.6.4 to 0.7.1 #2088

Open danbeechbloom opened 1 month ago

danbeechbloom commented 1 month ago

Environment

Technology Version
Flutter version 3.21.0-14.0.pre.13
Plugin version ^6.0.0
Android version N/A
iOS version N/A
macOS version N/A
Xcode version N/A
Google Chrome version N/A

Device information: N/A

Description

js version is ^0.6.4, it needs to be updated to ^0.7.1 or this package pins the js version and blocks updates to other packages.

Expected behavior:

js version should not pin other packages to earlier versions.

Current behavior: js version pins packages to earlier js version, blocking updates

Steps to reproduce

  1. Add this package to your pubspec.yaml
  2. add another package that has updated their js version (e.g. mixpanel @ v2.3.0)
  3. flutter pub get
github-actions[bot] commented 1 month ago

👋 @danbeechbloom

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

dreyescabrera commented 1 month ago

This is a serious problem

tigrenok00 commented 1 month ago

I have the same issue

tigrenok00 commented 1 month ago

It is blocking us from upgrading flutter and other dependencies as there is no other good alternative to in app webview, can you please resolve this ASAP?

hellohejinyu commented 4 weeks ago
image

The js package provides support for the web platform. If your project does not use the web platform, you can override the js version through dependency_overrides, so that it will not affect the updates of other packages.

romatallinn commented 4 weeks ago

If your project does not use the web platform, you can override the js version

Just for others to clarify this. At first I was hesitant, taking into account that this package is an in-app web browser, and I am using some js handlers, so was afraid to break something. But in the end, I looked up pubspec files and js is indeed included only in web-specific package. So it's indeed safe for flutter_inappwebview to override it if web isn't used (until a proper update is pushed).

tigrenok00 commented 4 weeks ago

In our case we do use flutter web too, so the js dependency is needed and its blocking us from upgrading flutter currently