bugfix/ajax-blob - Githubissues

pichillilorenzo / flutter_inappwebview

A Flutter plugin that allows you to add an inline webview, to use a headless webview, and to open an in-app browser window.

https://inappwebview.dev

Apache License 2.0

3.01k stars 1.33k forks source link

bugfix/ajax-blob #2099

Open EArminjon opened 1 month ago

EArminjon commented 1 month ago

Smell like code issue. blob variable used previously was not defined. On blob, request.response contain a blob object, let's use it.

Connection with issue(s)

Resolve issue https://github.com/pichillilorenzo/flutter_inappwebview/issues/2098

Connected to https://github.com/pichillilorenzo/flutter_inappwebview/issues/2098

Testing and Review Notes

Screenshots or Videos

To Do

[X] double check the original issue to confirm it is fully satisfied
[ ] add testing notes and screenshots in PR description to help guide reviewers
[ ] request the "UX" team perform a design review (if/when applicable)

EArminjon commented 4 weeks ago

@pichillilorenzo

I wonder about the following code callback(null) :

Capture d’écran 2024-04-16 à 14 38 23

I believe we should also give request.response because what will happen if reques.response exist and request.responseType is null ? We lost the result...