pichillilorenzo / flutter_inappwebview

A Flutter plugin that allows you to add an inline webview, to use a headless webview, and to open an in-app browser window.
https://inappwebview.dev
Apache License 2.0
3.31k stars 1.64k forks source link

shouldOverrideUrlLoading called on page loading for pages with embedded youtube player on iOS #800

Closed akadatsky closed 3 years ago

akadatsky commented 3 years ago

Environment

Technology Version
Flutter version 1.22.6
Android version 11
iOS version 12.1

Device information: iPhone 6s

Description

I want to open some page in webview and if user click on youtube link open it in native app. I use shouldOverrideUrlLoading callback to handle redirect. For Android it works ok, but for iOS shouldOverrideUrlLoading triggered when the page with embedded youtube player is loaded, for example https://events.flutter.dev.

Expected behavior: shouldOverrideUrlLoading does not called on page loading for pages with embedded youtube player on iOS

Current behavior: shouldOverrideUrlLoading called on page loading for pages with embedded youtube player on iOS

Steps to reproduce

Open some page with with embedded youtube player, for example https://events.flutter.dev and handle shouldOverrideUrlLoading callback:

        InAppWebView(
          initialUrl: 'https://events.flutter.dev',
          initialOptions: InAppWebViewGroupOptions(
            crossPlatform: InAppWebViewOptions(
              debuggingEnabled: true,
              useShouldOverrideUrlLoading: true,
              clearCache: true,
              mediaPlaybackRequiresUserGesture: false,
            ),
          ),
          shouldOverrideUrlLoading: (controller, request) async {
            final uri = Uri.parse(request.url);
            if (uri.host.contains('youtube.com')) {
              launch(request.url);
              return ShouldOverrideUrlLoadingAction.CANCEL;
            }
            return ShouldOverrideUrlLoadingAction.ALLOW;
          },
        )
github-actions[bot] commented 3 years ago

👋 @akadatsky

NOTE: This comment is auto-generated.

Are you sure you have already searched for the same problem?

Some people open new issues but they didn't search for something similar or for the same issue. Please, search for it using the GitHub issue search box or on the official inappwebview.dev website, or, also, using Google, StackOverflow, etc. before posting a new one. You may already find an answer to your problem!

If this is really a new issue, then thank you for raising it. I will investigate it and get back to you as soon as possible. Please, make sure you have given me as much context as possible! Also, if you didn't already, post a code example that can replicate this issue.

In the meantime, you can already search for some possible solutions online! Because this plugin uses native WebView, you can search online for the same issue adding android WebView [MY ERROR HERE] or ios WKWebView [MY ERROR HERE] keywords.

Following these steps can save you, me, and other people a lot of time, thanks!

pichillilorenzo commented 3 years ago

You can simply use the request.isForMainFrame property to detect if that request is, well, for the main frame or not. If it is false, then, in your scenario, just ignore that request returning ShouldOverrideUrlLoadingAction.ALLOW.

github-actions[bot] commented 1 month ago

This thread has been automatically locked since there has not been any recent activity after it was closed. If you are still experiencing a similar issue, please open a new bug and a minimal reproduction of the issue.