picimako / terra-support

Adds support for Cerner's Terra UI component and test automation libraries.
https://plugins.jetbrains.com/plugin/15430-terra-support
Apache License 2.0
0 stars 0 forks source link

Screenshot view is opened upon renaming in the Terra wdio tool window #24

Closed picimako closed 3 years ago

picimako commented 3 years ago

Steps to reproduce

  1. Open the Terra Wdio tool window
  2. Start renaming a screenshot via the context menu action.
  3. Hit enter in the rename popup dialog.

Expected results

The dialog closes and the screenshot is not opened.

Actual results

The dialog closes and the screenshot opens in a new editor.

Technical notes

The issue happens only when hitting Enter in the dialog, but not when clicking on the Ok button. This is because there is focus on the screenshot node being renamed, in the tool window, and since opening one of the screenshot views is bound to the Enter shortcut key, it is triggered as well.

A feasible solution could be to remove the focus from the screenshot node right before the rename dialog is opened.

Versions affected

0.1.0, 0.2.0, 0.3.0

Out of scope

picimako commented 3 years ago

Completed.