larrythecucumber321
commented
2 years ago Implemented in #457
Comments:
- I don't think the "Max" button is needed. 4 years/end of slider is obvious max imo
- Extend lock failing is due to a MM issue, please try it again
- Gas estimates out of scope
- Revenue share stats
- APY breakdown will be done as part of ve(3,3) PR
- Average lock duration added
- APR is already projected
- PE/PS not necessary imo (not aware of other defi protocols doing this)
See deployment here https://pickle-ui-git-fix-v2-dill-picklefinance.vercel.app/
janklimo
[x] add the $PICKLE balance in-wallet and the $PICKLEs locked in the current $DILL lock (and maybe their worth in $) so it's easy to grasp if I need to lock anything.
[ ]
may need buttons to refresh balances in modals, this is because I am sure my balance changed while the page was already loaded but I had to refresh the whole page as when I clicked the modal by balance was zero.[x]
increase_amount()call failed: https://etherscan.io/tx/0x75d57d3c1c9d45baa98f89bacf79b35b34635f15f8f1b3958ec1fb892795e92b[x] extend lock modal opens and default state seems there's a visual bug.
[ ] I was unsure whether I was extending lock for the max amount or not.
[x] extend lock transaction couldn't be even relayed
[x] gas estimates were off throughout
[x] more indicators are needed in the revenue distribution stats element
[ ] another cosmetic improvement would be if the "pie chart" image here we could use the "identicons" by Dan Finlay that are very classic to Ethereum https://www.npmjs.com/package/ethereum-identicon