Closed robinwhittleton closed 2 months ago
Here I thought I had done good work eliminating some typos from the text, only to introduce a couple of my own in the longdesc!
I have accomplished a rebase or two in the past, and the commit history here is very straightforward. I'll rebase and force push to fix the Editorial commit messages (fingers crossed) and then tackle the rest.
Thanks very much!
Rebase done with reworded commit messages. I will update the thread again when I've taken care of the rest.
OK. All updates complete, and in my environment se lint .
returns clean.
Looks good! Couple more minor things:
Munsey’s Magazine
(in the longdesc) needs italics: https://standardebooks.org/manual/1.8.0/single-page#8.2.11.2W.
in the colophon needs an <abbr epub:type="z3998:given-name">
OK, done!
Really nice production, just a few things left to tackle.
general:
typogrify
makes a couple of reasonable changesepub:type="ordinal z3998:roman"
can be applied directly to theh3
. Hopefully this should be easy enough with a find and replace.se build-title .
se build-toc .
. This also introduces the correct ToC indentation for the book / chapter model.[Editorial]
changes, and we should remove this from the commit messages. How do you feel about rebasing?content.opf:
hygeine
->hygiene
hygeine
->hygiene
file-as
is different to the normal name. Typically we’d have thefile-as
as just being a rearrangement of the normal name. So here I’d expect it to be “McInnes, W. Beckwith”. You can always add afull-name
entry with William included.chapter-1-1:
se-lint-ignore.xml
file in the root of the project. More info at https://standardebooks.org/manual/1.8.0/single-page#2.3chapter-1-12:
[Editorial]
commit? They’re not referencing the works the characters appear in as far as I can tell.colophon:
L.
needs an<abbr epub:type="z3998:given-name">
Alex Krieger
needs to be wrapped in a<b epub:type="z3998:personal-name">