search

picklesdoc / pickles

The open source living documentation generator
http://www.picklesdoc.com/
Apache License 2.0
464 stars 164 forks source link

VsTestScenarioOutlineExampleMatcher fails to match on examples with comma in the first column #543

Closed psoszynski closed 4 years ago

psoszynski commented 6 years ago

Adding ".Replace(",", String.Empty)" to:

        var matchValue = exampleValues[0]
            .Replace(" ", string.Empty)
            .Replace(":", string.Empty)
            .Replace("\\", string.Empty)
            .Replace("(", string.Empty)
            .Replace(")", string.Empty)
            .Replace(".", "_")
            .Replace("!", string.Empty)
            .Replace("&", string.Empty)
            .ToUpperInvariant()
            .Replace("Ä", "A")
            .Replace("Ö", "O")
            .Replace("Ü", "U")
            .Replace("ß", "B")
            .Replace("æ", "ae")
            .Replace('ø', 'o')
            .Replace('å', 'a')
            .Replace("Æ", "AE")
            .Replace('Ø', 'O')
            .Replace('Å', 'A');

fixes the problem. Shall I create pull request?

rik-smeets commented 6 years ago

This is resolved by my PR as well, which is already opened for review: #542.

dirkrombauts commented 6 years ago

And I will review the PR today.