search

picklesdoc / pickles

The open source living documentation generator
http://www.picklesdoc.com/
Apache License 2.0
464 stars 164 forks source link

Support .net 6 in addition to existing frameworks #625

Closed andreyleskov closed 2 years ago

andreyleskov commented 2 years ago

Merry Christmas! Thanks again for the great project, here at CoverGo we use pickles to generate cucumber JSON to use within Behave.Pro Jira plugin

We are using pickles on macOS ARM in a project using .net 6. It is convenient to build projects, run tests and run pickles within the same DockerFile using the same base image for .net6 This PR is adding .Net 6 support to the existing frameworks. There are a couple of red tests due to missing native libraries, but we use this version successfully already, and I'm not sure how to fix these tests.

There is Autofac version bump from 4.0.0 to 6.3.0 as it has issues with .net 6 during the build

There is a small behavior change in .net 6 when multiple files get copied to the output with the same name.In .net 5 it was ok, just a file overwrite. In .net6 it will lead to an error. Because of this change, after migration to .net 6 pickles have a compile-time error with complaints about NLog.config in the pickles command line project. We are configuring the project to use the old behavior from .net 5 via "ErrorOnDuplicatePublishOutputFiles" attribute

ericcmmi commented 2 years ago

Hi @andreyleskov, sorry it has taken me so long to get to this. I see the error in the unit tests and I'm pretty sure I can resolve them. I will try to do that in the next few days and get this pulled in. Thanks for your contribution!

andreyleskov commented 2 years ago

@ericcmmi no worries, we are using our own-built version of pickles based on this PR, so there is no pressure.