picklesdoc / pickles

The open source living documentation generator
http://www.picklesdoc.com/
Apache License 2.0
464 stars 162 forks source link

Cannot upgrade .Net 4.8 project to 3.0.1 #629

Closed ccbristo closed 2 years ago

ccbristo commented 2 years ago

When I try to update from pickles 2.21.1 to 3.0.1 in my .Net 4.8 project, I get this error:

Package 'Pickles.CommandLine 3.0.1' has a package type 'DotnetTool' that is not supported by project

It is my understanding that pickles 3.x still supports .Net framework 4.8 (i.e. I don't need to be on .Net Core/.Net 5) to use it.

Is this an error in the Nuget package, am I doing something wrong, or is this expected?

ericcmmi commented 2 years ago

Pickles 3.0.1 is written to the dotnet standard so it can be compiled to core or framework but the Nuget package is compiled as dotnet core. I need to do some research how to support Nuget packages for both framework and dotnet core. I will try to get this done quickly.

ccbristo commented 2 years ago

Thanks for the response Eric. If there is anything I can do to help, feel free to reach out to me. I'm happy to help test or assist in fixing it if there's anything I can do.

ericcmmi commented 2 years ago

If you are still needing to update, try using Pickles.CommandLine.net4 version 4.0.1. I generated the Nuget package specifically without the dotnet tool setting and targeted for dotnet framework 4.8. Hopefully this will work for you.

ccbristo commented 2 years ago

Thanks Eric - the new package seems to have done the trick. I'll let you know if we run into anything else.